On Wed, Nov 03, 2021 at 08:01:38PM +0100, Claudio Jeker wrote:
> On Wed, Nov 03, 2021 at 12:41:52PM -0600, Theo de Raadt wrote:
> > +       size_t           talid; /* covered by which TAL */
> > 
> > You shouldn't use size_t
> > 
> > It is 32bit on ILP32 systems, and 64bit on I32LP64 machines, because the
> > underlying definition is:
> > 
> > _types.h:typedef        unsigned long           __size_t;
> > 
> > So suspect you want to use int or u_int.
> 
> Other code uses size_t because the ids are used as index in arrays.
> It is overkill here the maximum number of TAL is 8 right now. That fits in
> any kind of int. 
> 
> Here an adjusted diff

ok tb

Reply via email to