On Wed, Nov 10, 2021 at 04:28:10PM +0100, Bjorn Ketelaars wrote:
> Like umb(4), sppp(4) is natively learning DNS information. Diff below
> adds this information to the manpages of resolv(8) and unwindctl(8).
> While here, also mention umb(4) in unwindctl's manpage.
> 
> Thanks to kn@ for noticing the above.

I still want to polish all this in relation to route(8)'s `nameserver'
command... resolvd and unwind learn the same way but have different text
and they don't mention the static proposals...

But your diff goes in the right direction and I don't want to drag you
into this nit-picking business;  see inline.

> diff --git sbin/resolvd/resolvd.8 sbin/resolvd/resolvd.8
> index 71d0e40567e..d8c46d1972d 100644
> --- sbin/resolvd/resolvd.8
> +++ sbin/resolvd/resolvd.8
> @@ -48,6 +48,8 @@ also monitors the routing socket for proposals learned by
>  .Xr dhcpleased 8 ,
>  .Xr slaacd 8 ,
>  or network devices which natively learn DNS information such as
> +.Xr sppp 4
> +or
>  .Xr umb 4 .
>  Proposals can also be sent using the
>  .Xr route 8

OK kn for above hunk.

> diff --git usr.sbin/unwindctl/unwindctl.8 usr.sbin/unwindctl/unwindctl.8
> index 1b1be4451e7..a5c74c6303f 100644
> --- usr.sbin/unwindctl/unwindctl.8
> +++ usr.sbin/unwindctl/unwindctl.8
> @@ -58,9 +58,12 @@ Show a status summary.
>  .It Cm status autoconf
>  Show nameservers learned from
>  .Xr dhclient 8 ,
> -.Xr dhcpleased 8
> +.Xr dhcpleased 8 ,
> +.Xr slaacd 8 ,
> +or network devices which natively learn DNS information such as
> +.Xr sppp 4
>  or
> -.Xr slaacd 8 .
> +.Xr umb 4 .
>  .It Cm status memory
>  Show memory consumption.
>  .El

I think only unwind(8) should list all the inputs and unwindctl(8)
should just say "Show learned nameservers".

unwind(8) is already incomplete regardless of sppp(4) and unwindctl(8)
is a poor duplicate of it.

Reply via email to