On 2021/12/01 20:58, Krzysztof Kanas wrote: > On 2021-12-01 10:21, Klemens Nanni wrote: > > On Fri, Nov 26, 2021 at 01:35:14PM +0100, Krzysztof Kanas wrote: > > > Hi. When remote side in sppp doesn't reply for to PPP IPCP IP-Address > > > sppp will try to negotiate remote IP in endless loop. Instead use > > > 10.64.64.1 + if_index as remote IP. > > > > Why add some arbitrary RFC 1918 IP if negotiation fails? That's not > > what users request or expect. > > > > I agree that is unexpected but I couldn't find any info in RFC's what to > do if remote side don't reply. I am not familiar enough with PPP/SPP, > so I tried simples thing I could think of, which is to assign RFC 1918 > IP address.
IMHO: either keep waiting (the other side may complete IPCP later), or after X retries then drop the session and reattempt negotiation from scratch. A session that is up and stuck with a bogus IP is probably worse than a session that keeps trying to negotiate an address isn't it? How are you configuring the interface? Due to the race condition with "auto up" behaviour on the interface, I would recommend something like this in hostname.pppoeX, you need to have the dest address set to 0.0.0.1 *before* the interface comes up and if you follow the "clean" example in the manpage that doesn't always work inet 0.0.0.0 255.255.255.255 0.0.0.1 pppoedev em1 authproto chap authname "xyz@foo" authkey "fnord" up This abuses the fact that the dest address in stored in the same variable as the broadcast address on an ethernet interface (my diff to change the example in the manual previously was rejected due to this) but it works ok everywhere I've tried it and "dest" on a separate line doesn't.
