On Mon, Jan 10, 2022 at 04:35:41PM +0100, Tobias Heider wrote: > On Mon, Jan 10, 2022 at 04:20:36PM +0100, Stefan Sperling wrote: > > On Mon, Jan 10, 2022 at 03:50:45PM +0100, Tobias Heider wrote: > > > Makes sense. I also fixed the one in sdmmc_mem_send_cxd_data(). > > > > Doesn't build here, there a few errors like this: > > > > /usr/src/sys/dev/sdmmc/sdmmc_mem.c:483:1: error: unused label 'out' > > [-Werror,-Wu > > nused-label] > > > > I like Visa's idea of using early 'return ENOMEM' instead of goto. > > I removed the unused goto labels and cleaned up the error handling. > We don't need to check for (ptr != NULL) and in one case we can > merge two 'if (error == 0)' blocks. > > ok?
OK visa@
