On Sun, 13 Mar 2022 13:26:13 +0100, Jeremie Courreges-Anglas wrote: > Works fine. Here's an updated diff with suggestions: > - "k" was not completely removed from compress's struct compressor opt > string, and was not needed in null_method > - try to keep the *flag variables ordered > - rework the condition that decides whether we unlink and print > a warning message. I found the existing code not much readable with > a chain of flags check, a syscall and another flag check. > Also the new line was over 80 chars. > - adding "k" to usage can be made shorter since "L" is next to "k"
Looks good to me. OK millert@ for this version of the diff. - todd
