On Tue, Jul 12, 2022 at 05:19:17PM +0200, Claudio Jeker wrote:
>
> Updated diff below including changes suggested by jmc@
> --
> :wq Claudio
>
i think it reads ok now. but i have one more comment:
> Index: bgpd.8
> ===================================================================
> RCS file: /cvs/src/usr.sbin/bgpd/bgpd.8,v
> retrieving revision 1.74
> diff -u -p -r1.74 bgpd.8
> --- bgpd.8 28 Jun 2022 11:52:24 -0000 1.74
> +++ bgpd.8 11 Jul 2022 13:22:05 -0000
> @@ -401,6 +401,16 @@ has been started.
> .Re
> .Pp
> .Rs
> +.%A D. Walton
> +.%A A. Retana
> +.%A E. Chen
> +.%A J. Scudder
> +.%D July 2016
> +.%R RFC 7911
> +.%T Advertisement of Multiple Paths in BGP
> +.Re
> +.Pp
> +.Rs
> .%A C. Petrie
> .%A T. King
> .%D May 2017
> Index: bgpd.conf.5
> ===================================================================
> RCS file: /cvs/src/usr.sbin/bgpd/bgpd.conf.5,v
> retrieving revision 1.223
> diff -u -p -r1.223 bgpd.conf.5
> --- bgpd.conf.5 28 Jun 2022 11:52:24 -0000 1.223
> +++ bgpd.conf.5 12 Jul 2022 15:12:30 -0000
> @@ -843,6 +843,57 @@ The default is
> .Ic no .
> .Pp
> .It Xo
> +.Ic announce add-path send
> +.Pq Ic no Ns | Ns Ic all
> +.Xc
> +.It Xo
> +.Ic announce add-path send
> +.Pq Ic best Ns | Ns Ic ecmp | Ns Ic as-wide-best
> +.Op Ic plus Ar num
> +.Op Ic max Ar num
> +.Xc
> +If set to
> +.Ic all ,
> +.Ic best ,
> +.Ic ecmp ,
> +or
> +.Ic as-wide-best ,
> +the send add-path capability is announced, which allows sending multiple
> paths
> +per prefix.
> +Which paths are sent depends on the mode:
this sentence sounds odd, because "Which" usually starts a question. i'd
maybe go with:
The paths sent depend on the mode:
or
The paths sent depend on which mode is selected:
the second is clearer i suppose, but longer.
jmc
> +.Pp
> +.Bl -tag -width as-wide-best -compact
> +.It Ic all
> +send all valid paths
> +.It Ic best
> +send the best paths
> +.It Ic ecmp
> +send prefixes with equal nexthop cost
> +.It Ic as-wide-best
> +send prefixes where the first 8 checks of the decision process match
> +.El
> +.Pp
> +.Ic plus
> +allows the inclusion of additional backup paths and works for
> +.Ic best ,
> +.Ic ecmp ,
> +and
> +.Ic as-wide-best .
> +.Ic max
> +can be used to limit the total amount of paths sent for
> +.Ic ecmp
> +and
> +.Ic as-wide-best .
> +The default is
> +.Ic no .
> +.Pp
> +Right now
> +.Ic ecmp
> +and
> +.Ic as-wide-best
> +are equivalent.
> +.Pp
> +.It Xo
> .Ic announce as-4byte
> .Pq Ic yes Ns | Ns Ic no
> .Xc
>
