On Fri, Jul 22, 2022 at 03:03:40PM +0200, Alexander Bluhm wrote: > On Fri, Jul 22, 2022 at 10:38:32AM +0000, Klemens Nanni wrote: > > timeout_set_flags() explains the flag and the next paragraph would simply > > repeat it. > > > > timeout_set_proc() can be described simpler, just like what the > > actual function does; this way I don't feel having just read the > > same sentence twice. > > The current text describes the intension of the function. You > change it to an implementation detail. The timeout_set_proc() is > a commonly used API, timeout_set_flags() is barely used.
True. Anyways, Scott's timeout.9 revamp probably covers this. > Instead of adding a redirection in the man page to an unused function, > I would make timeout_set_flags() private to kern_timeout.c. Dthen > it needs no documentation. That's also possible. Either timeout_set_flags() is overkill and there won't be any flags soon or its work-in-progress and should stay as-is. I'd leave this to Scott, then.