On Sat, Aug 20, 2022 at 09:04:23PM -0400, Daniel Dickman wrote:
> We have some generic PCI devices names:
> 
> product TRANSMETA MEM1         0x0396  Mem1
> product TRANSMETA MEM2         0x0397  Mem2
> 
> Likely because these devices both appear as class=5 and subclass=0 (which 
> indicates a RAM device):
> 
> # pcidump -v
> ...
>  0:0:1: Transmeta Mem1
>         0x0000: Vendor ID: 1279, Product ID: 0396
>         0x0004: Command: 0000, Status: 0000
>         0x0008: Class: 05 Memory, Subclass: 00 RAM,
> 
> 
> NetBSD has:
> 
> product TRANSMETA SDRAM               0x0396  SDRAM Controller
> product TRANSMETA BIOS_SCRATCH        0x0397  BIOS Scratchpad
> 
> The Transmeta BIOS Programmer's Guide appears to confirm that the NetBSD 
> device names are correct. A copy of this guide is here:
> 
> http://datasheets.chipdb.org/Transmeta/Crusoe/TM5800/TM5800_BIOSGuide_6-14-02.pdf
> 
> Patch below updates the PCI device names for these 2 devices.
> 
> ok?
> 
> 
> Index: pcidevs
> ===================================================================
> RCS file: /cvs/src/sys/dev/pci/pcidevs,v
> retrieving revision 1.2001
> diff -u -p -u -r1.2001 pcidevs
> --- pcidevs   16 Aug 2022 09:28:45 -0000      1.2001
> +++ pcidevs   21 Aug 2022 00:52:28 -0000
> @@ -8886,8 +8886,8 @@ product TOSHIBA2 SDCARD         0x0805  SD
>  /* Transmeta products */
>  product TRANSMETA NB         0x0295  Northbridge
>  product TRANSMETA LONGRUN_NB 0x0395  LongRun Northbridge
> -product TRANSMETA MEM1               0x0396  Mem1
> -product TRANSMETA MEM2               0x0397  Mem2
> +product TRANSMETA SDRAM              0x0396  SDRAM Controller
> +product TRANSMETA BIOS_SP    0x0397  BIOS Scratchpad

why not just

product TRANSMETA SDRAM         0x0396  SDRAM
product TRANSMETA BIOS          0x0397  BIOS

Reply via email to