On Thu, Sep 15, 2022 at 10:36:40AM +1000, Jonathan Gray wrote: > On Wed, Sep 14, 2022 at 12:49:48PM -0400, Kurt Mosiejczuk wrote: > > This adds the IDs for the thunderbolt 3 controller parts in my T490
> > ok? > Shouldn't this be JHL6240 not JHL6420? > https://downloadmirror.intel.com/28658/eng/tbt_release_notes_17.4.77.400.txt > JHL6240 Series - "Alpine Ridge LP" > https://ark.intel.com/content/www/us/en/ark/products/94030/intel-jhl6240-thunderbolt-3-controller.html I mean, sure, if you want to be a hidebound "put the digits in the correct order" kind of person. :D Corrected diff below. --Kurt Index: pcidevs =================================================================== RCS file: /cvs/src/sys/dev/pci/pcidevs,v retrieving revision 1.2004 diff -u -p -r1.2004 pcidevs --- pcidevs 2 Sep 2022 10:34:07 -0000 1.2004 +++ pcidevs 15 Sep 2022 00:50:17 -0000 @@ -4008,6 +4008,9 @@ product INTEL I219_LM7 0x15bb I219-LM product INTEL I219_V7 0x15bc I219-V product INTEL I219_LM6 0x15bd I219-LM product INTEL I219_V6 0x15be I219-V +product INTEL JHL6240 0x15bf JHL6240 Thunderbolt 3 +product INTEL JHL6240_PCIE 0x15c0 JHL6240 Thunderbolt 3 +product INTEL JHL6240_XHCI 0x15c1 JHL6240 Thunderbolt 3 product INTEL X550EM_A_KR 0x15c2 X553 Backplane product INTEL X550EM_A_KR_L 0x15c3 X553 Backplane product INTEL X550EM_A_SFP_N 0x15c4 X553 SFP+