> On 16/09/22 12:20 +0000, Miod Vallat wrote:
> > > Index: dev/hid/hidkbdtrans.h
> >
> > > +static const struct hidkbd_translation apple_fn_trans[] = {
> >
> > No effing way. Every file including this header will embed its own copy
> > of these tables.
> >
> > Better keep the tables in their original locations. The munge interfaces
> > already take a pointer to a table and its number of elements, there is
> > no need to gather all these tables in one particular location.
>
> yeah was quiet stupid of me.. new diff here. i've also put the whole
> thing inside !SMALL_KERNEL
That's better.
However:
- I see no reason for this to be wrapped within !SMALL_KERNEL, having a
working keyboard within the installer is always a good thing.
- there is also no reason to move the Gdium-specific (loongson) bits
away from ukbd.c. They will never appear on any other kind of
keyboard. As long as there is a prototype for hidkbd_translate()
somewhere, it will keep working.
