There is an extra space in the output of ext communities of type OVS.
It seems when fmt_ext_community was introduced the extra space was not
removed from those special ext-communities.

This was noticed by job@
-- 
:wq Claudio

Index: bgpctl.c
===================================================================
RCS file: /cvs/src/usr.sbin/bgpctl/bgpctl.c,v
retrieving revision 1.283
diff -u -p -r1.283 bgpctl.c
--- bgpctl.c    31 Aug 2022 15:00:53 -0000      1.283
+++ bgpctl.c    27 Sep 2022 21:11:39 -0000
@@ -989,19 +989,19 @@ fmt_ext_community(uint8_t *data)
                ext = be64toh(ext) & 0xffffffffffffLL;
                switch (ext) {
                case EXT_COMMUNITY_OVS_VALID:
-                       snprintf(buf, sizeof(buf), "%s valid ",
+                       snprintf(buf, sizeof(buf), "%s valid",
                            log_ext_subtype(type, subtype));
                        return buf;
                case EXT_COMMUNITY_OVS_NOTFOUND:
-                       snprintf(buf, sizeof(buf), "%s not-found ",
+                       snprintf(buf, sizeof(buf), "%s not-found",
                            log_ext_subtype(type, subtype));
                        return buf;
                case EXT_COMMUNITY_OVS_INVALID:
-                       snprintf(buf, sizeof(buf), "%s invalid ",
+                       snprintf(buf, sizeof(buf), "%s invalid",
                            log_ext_subtype(type, subtype));
                        return buf;
                default:
-                       snprintf(buf, sizeof(buf), "%s 0x%llx ",
+                       snprintf(buf, sizeof(buf), "%s 0x%llx",
                            log_ext_subtype(type, subtype),
                            (unsigned long long)ext);
                        return buf;

Reply via email to