David Gwynne <da...@gwynne.id.au> wrote:
> usbdevs has "?" in the optstring is passes to getopt, but doesn't handle
> it specially. this is unnecessarily different to everything else in the
> tree, so i want to remove it. ok?
>
> Index: usbdevs.c
> ===================================================================
> RCS file: /cvs/src/usr.sbin/usbdevs/usbdevs.c,v
> retrieving revision 1.34
> diff -u -p -r1.34 usbdevs.c
> --- usbdevs.c 12 Jul 2021 15:09:22 -0000 1.34
> +++ usbdevs.c 28 Oct 2022 01:59:52 -0000
> @@ -239,7 +239,7 @@ main(int argc, char **argv)
> uint8_t addr = 0;
> const char *errstr;
>
> - while ((ch = getopt(argc, argv, "a:d:v?")) != -1) {
> + while ((ch = getopt(argc, argv, "a:d:v")) != -1) {
> switch (ch) {
> case 'a':
> addr = strtonum(optarg, 1, USB_MAX_DEVICES-1, &errstr);
>
I thought we killed all of those two decades ago.
