On Wed, Nov 30, 2022 at 08:55:45AM -0700, Todd C. Miller wrote:
> On Wed, 30 Nov 2022 09:20:26 -0600, Scott Cheloha wrote:
>
> > Couple related things:
> >
> > - Use err(3) everywhere.
> >
> > For many of these errors we are not currently printing the errno
> > string. Is there any reason not to do so? The errno string is
> > useful.
>
> OK
>
> > - Set ifile/ofile to "stdin"/"stdout" if the user passes in
> > "-" to make the err(3) message a little more obvious.
>
> OK
>
> > - Add a usage() function.
>
> usage() should probably be marked __dead in the prototype.
Agreed.
While here, can you sync usage and manual? I think the latter is fine
and the former should be just that:
$ man -h midicat
midicat [-d] [-i file] [-o file] [-q port]
$ midicat -h
midicat: unknown option -- h
usage: midicat [-d] [-i in-file] [-o out-file] [-q in-port] [-q
out-port]
>
> Otherwise OK millert@
>
> - todd
>
