On Fri, 09 Dec 2022 19:48:02 +0300, Vitaliy Makkoveev wrote:

> This time, socket's buffer lock requires solock() to be held. I'm
> working on standalone socket's buffer locking, and I want to commit some
> bits. I mean SS_CANTSENDMORE and SS_CANTRCVMORE socket's state bits,
> which I want to turn into per buffer state. The diff below introduces
> per buffer `sb_state' and turns SS_CANTSENDMORE into SBS_CANTSENDMORE.
> This bit will be processed on `so_snd' buffer only.
>
> I want to move SS_CANTRCVMORE and SS_RCVATMARK bits with separate diff
> to make the review easier and exclude possible so_rcv/so_snd mistypes.
>
> Also, I don't want to adjust the remaining SS_* bits right now.

This looks fine to me.  It is nice that we get sb_state for free
since it is adjacent to sb_flags (also a short).

 - todd

Reply via email to