ok mvs@
> On 11 Dec 2022, at 01:46, Klemens Nanni <k...@openbsd.org> wrote:
>
> Dead since introduction in 2001 with icmp6.c r1.31:
> implement upper limit to icmp6 redirects (experimental, turned off)
> negative value to {mtudisc,redirect}_{hi,lo}wat will turn off the
> limitation.
> sync with kame.
>
> icmp6_redirect_lowat was always -1 and never hit the empty conditional.
>
> icmp6_redirect_hiwat never existed.
>
> icmp6_mtudisc_{hi,lo}wat are exposed as net.inet6.icmp6.mtudisc_{hi,lo}wat
> sysctl(2)s, so don't touch those for now.
>
> Feedback? OK?
>
> diff --git a/sys/netinet6/icmp6.c b/sys/netinet6/icmp6.c
> index 94612a560c3..7a64861d15f 100644
> --- a/sys/netinet6/icmp6.c
> +++ b/sys/netinet6/icmp6.c
> @@ -129,9 +129,6 @@ static int icmp6_mtudisc_lowat = 256;
> */
> struct rttimer_queue icmp6_redirect_timeout_q;
>
> -/* XXX experimental, turned off */
> -static int icmp6_redirect_lowat = -1;
> -
> void icmp6_errcount(int, int);
> int icmp6_ratelimit(const struct in6_addr *, const int, const int);
> const char *icmp6_redirect_diag(struct in6_addr *, struct in6_addr *,
> @@ -1386,12 +1383,6 @@ icmp6_redirect_input(struct mbuf *m, int off)
> rtcount = rt_timer_queue_count(&icmp6_redirect_timeout_q);
> if (0 <= ip6_maxdynroutes && rtcount >= ip6_maxdynroutes)
> goto freeit;
> - else if (0 <= icmp6_redirect_lowat &&
> - rtcount > icmp6_redirect_lowat) {
> - /*
> - * XXX nuke a victim, install the new one.
> - */
> - }
>
> bzero(&sdst, sizeof(sdst));
> bzero(&sgw, sizeof(sgw));
>
