I've only read through 50% of this so far, but there are a few issues:
On Thu, Dec 22, 2022 at 06:31:23PM -0500, Paul Tagliamonte wrote:
> Index: lib/libcurses/base/resizeterm.c
> ===================================================================
> RCS file: /cvs/src/lib/libcurses/base/resizeterm.c,v
> retrieving revision 1.4
> diff -u -p -r1.4 resizeterm.c
> --- lib/libcurses/base/resizeterm.c 10 Mar 2021 20:16:08 -0000 1.4
> +++ lib/libcurses/base/resizeterm.c 22 Dec 2022 21:14:13 -0000
> @@ -48,7 +48,7 @@ MODULE_ID("$Id: resizeterm.c,v 1.4 2021/
> #define stolen_lines (screen_lines - SP->_lines_avail)
>
> /*
> - * If we're trying to be reentrant, do not want any local statics.
> + * If we're trying to be reentrant, do not want any local statistics.
> */
> #if USE_REENTRANT
> #define EXTRA_ARGS , CurLines, CurCols
This is an incorrect change, and actually introduces a new error.
'Statics' here is entirely correct.
> Index: lib/libcrypto/objects/obj_dat.c
> ===================================================================
> RCS file: /cvs/src/lib/libcrypto/objects/obj_dat.c,v
> retrieving revision 1.50
> diff -u -p -r1.50 obj_dat.c
> --- lib/libcrypto/objects/obj_dat.c 26 Nov 2022 16:08:53 -0000 1.50
> +++ lib/libcrypto/objects/obj_dat.c 22 Dec 2022 21:14:12 -0000
> @@ -251,7 +251,7 @@ static IMPLEMENT_LHASH_DOALL_FN(cleanup2
> static IMPLEMENT_LHASH_DOALL_FN(cleanup3, ADDED_OBJ)
>
> /* The purpose of obj_cleanup_defer is to avoid EVP_cleanup() attempting
> - * to use freed up OIDs. If neccessary the actual freeing up of OIDs is
> + * to use freed up OIDs. If necessary the actual freeing up of OIDs is
> * delayed.
> */
>
> @@ -320,7 +320,7 @@ OBJ_add_object(const ASN1_OBJECT *obj)
> ao[i]->type = i;
> ao[i]->obj = o;
> aop = lh_ADDED_OBJ_insert(added, ao[i]);
> - /* memory leak, buit should not normally matter */
> + /* memory leak, built should not normally matter */
> free(aop);
> }
> }
This is wrong. You are changing 'buit' to 'built', but the correct word
would be 'but'.
> Index: include/rpc/rpc_des.h
> ===================================================================
> RCS file: /cvs/src/include/rpc/rpc_des.h,v
> retrieving revision 1.4
> diff -u -p -r1.4 rpc_des.h
> --- include/rpc/rpc_des.h 1 Sep 2010 14:43:34 -0000 1.4
> +++ include/rpc/rpc_des.h 22 Dec 2022 21:14:06 -0000
> @@ -9,7 +9,7 @@
> * The implementation was written so as to conform with Netscapes SSL.
> *
> * This library is free for commercial and non-commercial use as long as
> - * the following conditions are aheared to. The following conditions
> + * the following conditions are adhered to. The following conditions
> * apply to all code found in this distribution, be it the RC4, RSA,
> * lhash, DES, etc., code; not just the SSL code. The SSL documentation
> * included with this distribution is covered by the same copyright terms
> @@ -34,7 +34,7 @@
> * must display the following acknowledgement:
> * "This product includes cryptographic software written by
> * Eric Young ([email protected])"
> - * The word 'cryptographic' can be left out if the rouines from the
> library
> + * The word 'cryptographic' can be left out if the routines from the
> library
> * being used are not cryptographic related :-).
> * 4. If you include any Windows specific code (or a derivative thereof)
> from
> * the apps directory (application code) you must include an
> acknowledgement:
> @@ -52,7 +52,7 @@
> * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
> * SUCH DAMAGE.
> *
> - * The licence and distribution terms for any publically available version or
> + * The licence and distribution terms for any publicly available version or
> * derivative of this code cannot be changed. i.e. this code cannot simply
> be
> * copied and put under another distribution licence
> * [including the GNU Public Licence.]
You shouldn't change license texts, even for spelling correction, as you
are changing the license itself.
> Index: lib/libcrypto/arch/aarch64/opensslconf.h
> ===================================================================
> RCS file: /cvs/src/lib/libcrypto/arch/aarch64/opensslconf.h,v
> retrieving revision 1.1
> diff -u -p -r1.1 opensslconf.h
> --- lib/libcrypto/arch/aarch64/opensslconf.h 11 Jan 2017 18:11:01 -0000
> 1.1
> +++ lib/libcrypto/arch/aarch64/opensslconf.h 22 Dec 2022 21:14:10 -0000
> @@ -60,7 +60,7 @@
> /* Only one for the following should be defined */
> /* The prime number generation stuff may not work when
> * EIGHT_BIT but I don't care since I've only used this mode
> - * for debuging the bignum libraries */
> + * for debugging the bignum libraries */
> #define SIXTY_FOUR_BIT_LONG
> #undef SIXTY_FOUR_BIT
> #undef THIRTY_TWO_BIT
> @@ -90,7 +90,7 @@
> #endif
>
> /* This helps C compiler generate the correct code for multiple functional
> - * units. It reduces register dependancies at the expense of 2 more
> + * units. It reduces register dependencies at the expense of 2 more
> * registers */
> #ifndef DES_RISC1
> #undef DES_RISC1
> @@ -105,7 +105,7 @@ YOU SHOULD NOT HAVE BOTH DES_RISC1 AND D
> #endif
>
> /* Unroll the inner loop, this sometimes helps, sometimes hinders.
> - * Very mucy CPU dependant */
> + * Very mucy CPU dependent */
> #ifndef DES_UNROLL
> #define DES_UNROLL
> #endif
You've fixed 'dependent', but is 'mucy' correct? Should it be 'much'?
If we're going to edit the file, we might as well correct this as well,
if it's indeed a mistake.
This 'mucy' is also found in other places, by the way.
I think this diff would be much better if it was split up for easier
review.
