> +++ usr.bin/ctfconv/parse.c 22 Dec 2022 21:15:27 -0000 > @@ -72,7 +72,7 @@ RB_HEAD(itype_tree, itype) itypet[CTF_K > */ > struct isymb_tree isymbt; > > -struct itype *void_it; /* no type is emited for void */ > +struct itype *void_it; /* no type is emitted for void > */
style(9) issue, this exceeds 80 columns > --- usr.bin/dig/lib/dns/include/dns/name.h 14 Sep 2020 08:40:43 -0000 > 1.12 > +++ usr.bin/dig/lib/dns/include/dns/name.h 22 Dec 2022 21:15:27 -0000 > @@ -354,7 +354,7 @@ dns_name_equal(const dns_name_t *name1, > * \li Because it only needs to test for equality, dns_name_equal() > can be > * significantly faster than dns_name_fullcompare() or dns_name_compare(). > * > - * \li Offsets tables are not used in the comparision. > + * \li Offsets tables are not used in the comparison. probably "Offset tables are..." A bunch of the files in your diff come from external upstream sources which are still synced from upstream (or at least should be); patching in the OpenBSD tree makes it harder to merge in updates. (including at least curses, the "magic" files for file, nsd, unbound). If problems in those still exist upstream, fixes should be fed there instead of to OpenBSD (and we'll pick them up when next updated). Overall imho this is too much churn to do in huge swathes across the tree. Fixes for spelling/grammar in comments etc are often more usually done by people working on a particular part of the tree or trying to understand how something works, generally you do need someone in that sort of position to review the changes for each area. (Also they will have a better idea whether the diff is going to cause conflicts with other work in progress). I would prefer to have a misspelt comment than one where fixing a spelling has resulted in some incorrect change of meaning that hasn't been noticed because it was done as part of a huge diff..
