Hello, tech@!
Minor patch for `arp(8)`. It uses some spaces between two tabs that are
hard to notice. I have a syntax highlighting rule that shows such spaces[1]
so I saw it while reviewing the arp.c source.
I've learned my lesson trying to patch the monorepo across folder lines, so
here's a patch for only just arp.c, and a list of files that match a grep[2]
attached for someone else who feels the urge to be told off on the list -- I've
done exactly zero work to figure out if there's any false positives (spoiler,
there are just from scanning some of them) due to filetype[3] or source that's
not `style(9)` formatted yet; but I'll let someone else take that windmill on
if they're so inclined. I have become disinclined :)
Plus, I fear if I send another large diff after going through all these cases,
jmc@ won't have any free time this holiday season[4], and we can't have that.
```
Index: arp.c
===================================================================
RCS file: /cvs/src/usr.sbin/arp/arp.c,v
retrieving revision 1.88
diff -u -p -r1.88 arp.c
--- arp.c 16 Sep 2019 20:49:28 -0000 1.88
+++ arp.c 28 Dec 2022 04:49:15 -0000
@@ -418,7 +418,7 @@ tryagain:
if (sdl->sdl_family == AF_LINK && rtm->rtm_flags & RTF_LLINFO) {
if (rtm->rtm_flags & RTF_LOCAL)
return (0);
- if (!(rtm->rtm_flags & RTF_GATEWAY))
+ if (!(rtm->rtm_flags & RTF_GATEWAY))
switch (sdl->sdl_type) {
case IFT_ETHER:
case IFT_FDDI:
```
paultag
[1]: from my ~/.exrc for vim:
highlight NestedSpace ctermbg=red ctermfg=white guibg=red
match NestedSpace /\t \+\t/
[2]: {openbsd monks avert your eyes: gnu grep and bash w/ 'shopt -s extglob'}:
$ grep -P '\t +\t' !(gnu|sys) -ril
[3]: you can never be too sure; perhaps there's some whitespace
(the language) source in-tree
https://en.wikipedia.org/wiki/Whitespace_(programming_language)
[4]: if someone with eyes on jmc@ could give him some cookies as a thanks for
his hard work, the universe would be very thankful.
--
:wq
bin/ed/ed.h
bin/ed/io.c
bin/ed/main.c
bin/csh/proc.c
distrib/notes/alpha/hardware
etc/etc.powerpc64/MAKEDEV
etc/etc.powerpc64/MAKEDEV.md
games/hack/hack.end.c
games/hack/hack.shk.c
games/bs/bs.c
games/atc/update.c
games/phantasia/phantstruct.h
games/cribbage/cribcur.h
games/backgammon/backgammon/move.c
games/canfield/canfield/canfield.c
include/rpc/auth_unix.h
include/protocols/talkd.h
include/Makefile
include/resolv.h
lib/libkeynote/keynote-ver.l
lib/libkeynote/keynote-verify.c
lib/libkeynote/keynote.l
lib/libkeynote/keynote.y
lib/libpcap/grammar.y
lib/libpcap/optimize.c
lib/libfido2/src/u2f.c
lib/libcurses/tinfo/MKfallback.sh
lib/libform/form.h
lib/libsndio/sio_aucat.c
lib/csu/hppa/md_init.h
lib/libcrypto/engine/eng_cnf.c
lib/libcrypto/sha/asm/sha1-586.pl
lib/libcrypto/modes/gcm128.c
lib/libcrypto/modes/cfb128.c
lib/libcrypto/objects/objects.txt
lib/libcrypto/perlasm/x86_64-xlate.pl
lib/libcrypto/x509/x509_pmaps.c
lib/libcrypto/x509/x509.h
lib/libcrypto/rsa/rsa_lib.c
lib/libcrypto/whrlpool/wp_dgst.c
lib/libcrypto/util/mkstack.pl
lib/libcrypto/aes/asm/bsaes-x86_64.pl
lib/libm/src/e_log.c
lib/libm/src/e_fmod.c
lib/libm/src/e_rem_pio2f.c
lib/libm/src/e_cosh.c
lib/libm/src/e_rem_pio2.c
lib/libm/src/e_lgammaf_r.c
lib/libm/src/s_log1pf.c
lib/libm/src/s_expm1f.c
lib/libm/src/e_atan2f.c
lib/libm/src/s_log1p.c
lib/libm/src/e_sinh.c
lib/libm/src/s_erf.c
lib/libm/src/e_jnf.c
lib/libm/src/e_logf.c
lib/libm/src/k_rem_pio2.c
lib/libm/src/e_atan2.c
lib/libm/src/e_remainderf.c
lib/libm/src/k_rem_pio2f.c
lib/libm/src/s_expm1.c
lib/libm/src/e_sqrt.c
lib/libm/src/e_jn.c
lib/libm/src/e_fmodf.c
lib/libm/src/k_cos.c
lib/libm/src/e_lgamma_r.c
lib/libm/src/k_tan.c
lib/libm/src/e_expf.c
lib/libm/src/e_atan2l.c
lib/libm/src/k_sin.c
lib/libc/db/btree/bt_split.c
lib/libc/db/hash/hash.h
lib/libc/gdtoa/ldtoa.c
lib/libc/arch/powerpc/string/memmove.S
lib/libc/arch/amd64/string/ffs.S
lib/libc/arch/powerpc64/string/memmove.S
lib/libc/arch/i386/string/ffs.S
lib/libc/stdlib/merge.c
lib/libc/stdlib/malloc.c
lib/libc/stdlib/getopt_long.3
lib/libc/time/localtime.c
lib/libc/stdio/fvwrite.c
lib/libc/stdio/vfwscanf.c
lib/libmenu/eti.h
lib/libssl/d1_both.c
lib/libssl/ssl3.h
lib/libssl/tls1.h
libexec/ld.so/aarch64/SYS.h
libexec/ld.so/riscv64/SYS.h
libexec/tradcpp/array.h
libexec/login_ldap/aldap.h
libexec/spamd/grey.c
regress/lib/libm/msun/ctrig_test.c
regress/lib/libm/msun/invctrig_test.c
regress/lib/libc/popen/popen.c
regress/lib/libc/arch/alpha/divremtest/divremtest.c
regress/sys/kern/unveil/syscalls.c
regress/usr.bin/ssh/unittests/misc/test_strdelim.c
regress/usr.bin/tsort/tsort-check
regress/usr.bin/openssl/appstest.sh
regress/usr.sbin/pkg_add/Makefile
regress/bin/ksh/bksl-nl.t
regress/bin/ksh/th
sbin/dhcpleased/parse.y
sbin/ipsecctl/parse.y
sbin/dhclient/clparse.c
sbin/dhclient/kroute.c
sbin/pfctl/pfctl_parser.c
sbin/pfctl/parse.y
sbin/scsi/libscsi.c
sbin/mountd/mountd.c
sbin/iked/types.h
sbin/restore/dirs.c
sbin/sysctl/sysctl.c
sbin/unwind/libunbound/libunbound/libunbound.c
sbin/unwind/libunbound/services/cache/infra.c
sbin/unwind/libunbound/services/listen_dnsport.c
sbin/unwind/libunbound/services/localzone.c
sbin/unwind/libunbound/iterator/iter_utils.c
sbin/unwind/libunbound/iterator/iter_scrub.c
sbin/unwind/libunbound/iterator/iterator.c
sbin/unwind/libunbound/iterator/iter_resptype.c
sbin/unwind/libunbound/util/netevent.h
sbin/unwind/libunbound/util/config_file.c
sbin/unwind/libunbound/util/data/msgencode.c
sbin/unwind/libunbound/util/mini_event.c
sbin/unwind/libunbound/validator/val_sigcrypt.c
sbin/unwind/libunbound/validator/validator.c
sbin/unwind/libunbound/validator/val_anchor.c
sbin/unwind/libunbound/sldns/rrdef.c
sbin/unwind/libunbound/sldns/wire2str.c
sbin/unwind/libunbound/sldns/str2wire.c
sbin/unwind/libunbound/dns64/dns64.c
sbin/unwind/parse.y
sbin/fsck/preen.c
sbin/fsirand/fsirand.c
share/tmac/mdoc/doc-ditroff
share/man/man4/dt.4
share/man/man4/pf.4
share/man/man3/queue.3
usr.bin/ssh/rijndael.c
usr.bin/dig/lib/dns/dns_log.c
usr.bin/dig/lib/dns/dns_result.c
usr.bin/dig/lib/dns/include/dns/result.h
usr.bin/dig/lib/dns/include/dns/name.h
usr.bin/dig/lib/isc/include/isc/log.h
usr.bin/sort/vsort.c
usr.bin/mklocale/yacc.y
usr.bin/mg/dired.c
usr.bin/mg/fileio.c
usr.bin/mg/tags.c
usr.bin/mg/log.h
usr.bin/mg/interpreter.c
usr.bin/mg/main.c
usr.bin/mg/line.c
usr.bin/mg/def.h
usr.bin/mg/re_search.c
usr.bin/infocmp/infocmp.c
usr.bin/tmux/tmux.h
usr.bin/tmux/window-buffer.c
usr.bin/tmux/cmd-list-sessions.c
usr.bin/tmux/window-copy.c
usr.bin/tmux/input.c
usr.bin/tmux/window-client.c
usr.bin/tmux/window-clock.c
usr.bin/tmux/server-client.c
usr.bin/tmux/cmd-resize-window.c
usr.bin/tmux/layout-set.c
usr.bin/tmux/options.c
usr.bin/tmux/window-tree.c
usr.bin/tmux/layout.c
usr.bin/tmux/cmd-resize-pane.c
usr.bin/tmux/screen-write.c
usr.bin/tmux/screen-redraw.c
usr.bin/m4/tokenizer.l
usr.bin/m4/NOTES
usr.bin/at/parsetime.c
usr.bin/colrm/colrm.c
usr.bin/ldap/aldap.h
usr.bin/make/error.c
usr.bin/make/job.c
usr.bin/make/cond.c
usr.bin/make/make.c
usr.bin/make/suff.c
usr.bin/make/lowparse.c
usr.bin/make/compat.c
usr.bin/make/main.c
usr.bin/make/garray.h
usr.bin/make/dump.c
usr.bin/make/gnode.h
usr.bin/make/targequiv.c
usr.bin/make/engine.c
usr.bin/make/engine.h
usr.bin/make/parse.c
usr.bin/vi/common/options.c
usr.bin/vi/ex/ex_subst.c
usr.bin/mail/cmdtab.c
usr.bin/tsort/tsort.c
usr.bin/rdist/common.c
usr.bin/tput/tput.c
usr.bin/file/magdir/sql
usr.bin/file/magdir/audio
usr.bin/file/magdir/hp
usr.bin/file/magdir/msdos
usr.bin/ctfconv/ctfconv.c
usr.bin/ctfconv/dwarf.h
usr.bin/ctfconv/itype.h
usr.bin/ctfconv/parse.c
usr.bin/encrypt/encrypt.c
usr.bin/awk/awkgram.y
usr.bin/awk/lex.c
usr.bin/pkg-config/OpenBSD/PkgConfig.pm
usr.bin/pkg-config/pkg-config
usr.bin/mandoc/roff_int.h
usr.bin/locate/code/locate.code.c
usr.bin/tftp/main.c
usr.bin/pr/pr.c
usr.sbin/tcpdump/print-802_11.c
usr.sbin/tcpdump/print-ipsec.c
usr.sbin/tcpdump/ethertype.h
usr.sbin/tcpdump/print-ike.c
usr.sbin/lpr/common_source/displayq.c
usr.sbin/sensorsd/sensorsd.c
usr.sbin/lpd/printer.c
usr.sbin/crunchgen/crunchgen.c
usr.sbin/pkg_add/OpenBSD/Delete.pm
usr.sbin/pkg_add/OpenBSD/PackageName.pm
usr.sbin/pkg_add/OpenBSD/PackageRepository.pm
usr.sbin/pkg_add/OpenBSD/ProgressMeter/Term.pm
usr.sbin/pkg_add/OpenBSD/PkgInfo.pm
usr.sbin/pkg_add/OpenBSD/PkgSpec.pm
usr.sbin/pkg_add/OpenBSD/CollisionReport.pm
usr.sbin/pkg_add/OpenBSD/Update.pm
usr.sbin/pkg_add/OpenBSD/AddDelete.pm
usr.sbin/pkg_add/OpenBSD/PkgCheck.pm
usr.sbin/pkg_add/OpenBSD/PkgSign.pm
usr.sbin/pkg_add/OpenBSD/Ustar.pm
usr.sbin/pkg_add/OpenBSD/ArcCheck.pm
usr.sbin/pkg_add/OpenBSD/PkgCreate.pm
usr.sbin/pkg_add/OpenBSD/PkgDelete.pm
usr.sbin/pkg_add/OpenBSD/PkgAdd.pm
usr.sbin/pkg_add/OpenBSD/PackingList.pm
usr.sbin/pkg_add/OpenBSD/Dependencies.pm
usr.sbin/pkg_add/OpenBSD/PackageRepository/HTTP.pm
usr.sbin/pkg_add/OpenBSD/PackageRepository/Cache.pm
usr.sbin/pkg_add/OpenBSD/PackageRepository/Installed.pm
usr.sbin/pkg_add/OpenBSD/Dependencies/SolverBase.pm
usr.sbin/pkg_add/OpenBSD/Add.pm
usr.sbin/pkg_add/pkg_mklocatedb
usr.sbin/unwindctl/unwindctl.c
usr.sbin/bgpctl/mrtparser.h
usr.sbin/bgpctl/ometric.c
usr.sbin/ypldap/ypldap.h
usr.sbin/ypldap/aldap.h
usr.sbin/edquota/edquota.c
usr.sbin/vmd/parse.y
usr.sbin/authpf/authpf.c
usr.sbin/smtpd/mta.c
usr.sbin/smtpd/scheduler.c
usr.sbin/smtpd/smtpd.h
usr.sbin/smtpd/ruleset.c
usr.sbin/smtpd/smtpd-api.h
usr.sbin/smtpd/ssl.c
usr.sbin/unbound/libunbound/libunbound.c
usr.sbin/unbound/services/cache/infra.c
usr.sbin/unbound/services/listen_dnsport.c
usr.sbin/unbound/services/localzone.c
usr.sbin/unbound/smallapp/unbound-anchor.c
usr.sbin/unbound/doc/Changelog
usr.sbin/unbound/acx_nlnetlabs.m4
usr.sbin/unbound/daemon/daemon.c
usr.sbin/unbound/iterator/iter_utils.c
usr.sbin/unbound/iterator/iter_scrub.c
usr.sbin/unbound/iterator/iterator.c
usr.sbin/unbound/iterator/iter_resptype.c
usr.sbin/unbound/util/netevent.h
usr.sbin/unbound/util/config_file.c
usr.sbin/unbound/util/data/msgencode.c
usr.sbin/unbound/util/mini_event.c
usr.sbin/unbound/validator/val_sigcrypt.c
usr.sbin/unbound/validator/validator.c
usr.sbin/unbound/validator/val_anchor.c
usr.sbin/unbound/sldns/rrdef.c
usr.sbin/unbound/sldns/wire2str.c
usr.sbin/unbound/sldns/str2wire.c
usr.sbin/unbound/testcode/testpkts.h
usr.sbin/unbound/testcode/fake_event.c
usr.sbin/unbound/configure.ac
usr.sbin/unbound/dns64/dns64.c
usr.sbin/unbound/configure
usr.sbin/snmpd/application_legacy.c
usr.sbin/rad/parse.y
usr.sbin/npppd/npppd/ppp.h
usr.sbin/rpki-client/ometric.c
usr.sbin/ypserv/makedbm/makedbm.c
usr.sbin/mopd/otherOS/loop-linux2.c
usr.sbin/ospf6d/rde_lsdb.c
usr.sbin/nsd/xfrd.c
usr.sbin/nsd/ipc.c
usr.sbin/nsd/zparser.y
usr.sbin/nsd/doc/ChangeLog
usr.sbin/nsd/rrl.c
usr.sbin/nsd/acx_nlnetlabs.m4
usr.sbin/nsd/namedb.c
usr.sbin/nsd/mini_event.c
usr.sbin/nsd/radtree.c
usr.sbin/nsd/configlexer.lex
usr.sbin/nsd/configure
usr.sbin/acme-client/parse.h
usr.sbin/adduser/adduser.perl
usr.sbin/btrace/bt_parse.y
usr.sbin/btrace/btrace.c
usr.sbin/hostapd/parse.y
usr.sbin/pppd/cbcp.c
usr.sbin/pppd/options.c
usr.sbin/ospfd/ospfd.c
usr.sbin/ospfd/parse.y
usr.sbin/ldpd/init.c
usr.sbin/ldpd/ldpd.h
usr.sbin/ldpd/packet.c
usr.sbin/ldpd/labelmapping.c
usr.sbin/ldpd/kroute.c
usr.sbin/ldpd/hello.c
usr.sbin/ftp-proxy/ftp-proxy.c
usr.sbin/rpc.lockd/lockd_lock.c
usr.sbin/ntpd/ntpd.h
