On Wed, Jan 18, 2023 at 05:18:58PM +0100, Theo Buehler wrote: > On Wed, Jan 18, 2023 at 02:46:19PM +0100, Claudio Jeker wrote: > > This is the next step in vstate cleanup. > > Since the vstate is now part of struct filterstate use that information > > instead of passing an explicit vstate to the various update functions. > > It took me a moment to understand that rde_filterstate_clean() does not > zero the vstate, so the changes in rde_update.c preserve behavior. > That's not super intuitive to me, but if that's bound to stay this way,
Uhm, now I'm a bit confused. Where is the vstate used after calling rde_filterstate_clean()? I did not spot that issue in rde_update.c I think we could zero everyting in the filterstate during clean. Just to be sure. -- :wq Claudio
