Guess, the "Push solock() down to sosetopt()" diff is better.
On Sat, Jan 28, 2023 at 02:08:36PM +0300, Vitaliy Makkoveev wrote:
> It will be null op in any cases. I want to do this, because it allows
> to push solock() down to sosplice() and make future sblock()/solock()
> dances easier with standalone sblock().
>
> Index: sys/kern/uipc_socket.c
> ===================================================================
> RCS file: /cvs/src/sys/kern/uipc_socket.c,v
> retrieving revision 1.299
> diff -u -p -r1.299 uipc_socket.c
> --- sys/kern/uipc_socket.c 27 Jan 2023 21:01:59 -0000 1.299
> +++ sys/kern/uipc_socket.c 28 Jan 2023 10:59:50 -0000
> @@ -1932,7 +1932,8 @@ sosetopt(struct socket *so, int level, i
> mtod(m, struct splice *)->sp_max,
> &mtod(m, struct splice *)->sp_idle);
> }
> - break;
> +
> + return (error);
> #endif /* SOCKET_SPLICE */
>
> default:
>
