On Thu, Feb 23, 2023 at 10:25:15AM -0600, joshua stein wrote: > On Thu, 23 Feb 2023 at 17:05:53 +0100, Tobias Heider wrote: > > Wow, thank you for looking into this! I've used your version for a few days > > now and it works really well for me (on a m2 macbook air). I actually think > > the default works so well that we can default to 0 for param 143. > > > > IMO we can add it to the tree at this point to give others the change to > > test it before the diff gets even bigger. > > But please add properly named knobs to wsconsctl for this first, and > preferably for all of the other hidden settings that were added with > wstpad. Expecting users to enable, let alone find, > "mouse.tp.param=72:1" is ridiculous. > > On one of my laptops I wanted to disable the middle soft button and > had to dig through the code to figure out that I had to use > "wsconsctl mouse.tp.param=65:0". >
Absolutely. I assumed once it goes in it gets a name. I called it tp.mtbuttons in my intitial diff because that was the best thing I could come up with. The libinput docs call it "clickfinger" behavior [1]. I don't have a strong preference as long as it has a name. [1] https://wayland.freedesktop.org/libinput/doc/latest/clickpad-softbuttons.html#clickfinger