On Thu, Mar 02, 2023 at 01:53:34PM +0300, Vitaliy Makkoveev wrote: > I like to use LIST_HEAD_INITIALIZER(9) for consistency with other global > list initializations in netinet/. ok mvs@ with this.
Needs a little spacing and commment wording wrangling to stay < 80 chars. OK? Index: netinet/if_ether.c =================================================================== RCS file: /cvs/src/sys/netinet/if_ether.c,v retrieving revision 1.256 diff -u -p -r1.256 if_ether.c --- netinet/if_ether.c 31 Jan 2023 13:41:54 -0000 1.256 +++ netinet/if_ether.c 2 Mar 2023 11:18:07 -0000 @@ -105,7 +105,8 @@ struct niqueue arpinq = NIQUEUE_INITIALI /* llinfo_arp live time, rt_llinfo and RTF_LLINFO are protected by arp_mtx */ struct mutex arp_mtx = MUTEX_INITIALIZER(IPL_SOFTNET); -LIST_HEAD(, llinfo_arp) arp_list; /* [mN] list of all llinfo_arp structures */ +LIST_HEAD(, llinfo_arp) arp_list = + LIST_HEAD_INITIALIZER(arp_list); /* [mN] list of llinfo_arp structures */ struct pool arp_pool; /* [I] pool for llinfo_arp structures */ int arp_maxtries = 5; /* [I] arp requests before set to rejected */ int la_hold_total; /* [a] packets currently in the arp queue */
