On Sat, Mar 25, 2023 at 04:17:06PM +0000, Klemens Nanni wrote:
> The script takes multiple arguments and loops over them on its own,
> so no reason to handroll the loop.
>
> OK?
This makes sense to me. I wonder if MAKEDEV changed to allow multiple
arguments or if the original author didn't realize it.
> In case anyone wonders why explicit devices are passed while "all" is used:
> it only creates that many devices, so if during install you created,
> e.g. sd14, that won't be covered by "all", hence passing explicit devices.
>
> Index: install.sub
> ===================================================================
> RCS file: /cvs/src/distrib/miniroot/install.sub,v
> retrieving revision 1.1234
> diff -u -p -r1.1234 install.sub
> --- install.sub 10 Mar 2023 10:33:40 -0000 1.1234
> +++ install.sub 14 Mar 2023 16:47:32 -0000
> @@ -2931,13 +2931,9 @@ finish_up() {
> fi
>
> echo -n "Making all device nodes..."
> - (cd /mnt/dev; sh MAKEDEV all
> - # Make sure any devices we found during probe are created in the
> - # installed system.
> - for _dev in $(get_dkdevs) $(get_cddevs); do
> - sh MAKEDEV $_dev
> - done
> - )
> + # Make sure any devices we found during probe are created in the
> + # installed system.
> + (cd /mnt/dev; sh MAKEDEV $(get_dkdevs) $(get_cddevs) all)
> echo " done."
>
> # We may run some programs in chroot, and some of them might be
>
