On Sat, Mar 25, 2023 at 11:34:08PM +0000, Klemens Nanni wrote:
> On Sat, Mar 25, 2023 at 08:36:06PM +0100, Mark Kettenis wrote:
> > To be honest I think we should remove this from the installer scripts.
> >
> > This code tries to handle the case where we've just whacked the disk
> > we've booted from since we're trying to install on it. My current
> > advice to people is to put the "system" firmware on a different disk
> > than the OS (e.g. the firmware on uSD and the OS on USB). This only
> > tries to handle the pine64. The only thing that sets pine64 apart
> > from many other boards is that it was the first board we ran on.
>
> This pine64 code was added in 2017 and never changed since then, no other
> boards except apple and rpi (for good reasons) were handled, either.
>
> I've installed on a Pinebook Pro just find without md_installboot() bits
> for it, although probably never on the same disk I booted from.
>
> Here's the removal diff if anyone wants to commit or OK it.
this diff is incomplete
the pine64 part in ramdisk/list is still there
why keep the remaining parts in the boot images after that?
>
> > If we want to have support for updating the "system" firmware, we
> > probably should follow the apple model, where we handle this in
> > installboot. But the we probably should do a better job at curating
> > these firmwares. At this point I'm not even confident the firmware we
> > ship for pine64 actually works. We've basically stopped updating the
> > u-boot package because each update broke a subset of the boards we
> > supported.
>
> Can't speak for the pine64, but the Pinebook Pro is equally bad and I've
> already tried numerous other u-boot flavours, firmwares and what not to
> fix stuff... such a mess.
>
> The rpi case is a different story and must remain.
>
>
> Index: install.md
> ===================================================================
> RCS file: /cvs/src/distrib/arm64/ramdisk/install.md,v
> retrieving revision 1.37
> diff -u -p -r1.37 install.md
> --- install.md 25 Mar 2023 18:29:37 -0000 1.37
> +++ install.md 25 Mar 2023 23:23:04 -0000
> @@ -40,7 +40,6 @@ md_installboot() {
>
> case $(sysctl -n machdep.compatible) in
> apple,*) _plat=apple;;
> - pine64,pine64*(+)) _plat=pine64;;
> raspberrypi,*) _plat=rpi;
> esac
>
> @@ -63,10 +62,6 @@ md_installboot() {
> (cd /etc/firmware
> pax -rw apple-bwfm /mnt/etc/firmware)
> fi
> - ;;
> - pine64)
> - dd if=$_mdec/u-boot-sunxi-with-spl.bin of=${_disk}c \
> - bs=1024 seek=8 status=none
> ;;
> rpi)
> mount ${MOUNT_ARGS_msdos} ${_disk}i /mnt/mnt
>
>
