On Thu, Apr 13, 2023 at 01:23:23PM +0200, Theo Buehler wrote:
> On Thu, Apr 13, 2023 at 12:25:46PM +0200, Claudio Jeker wrote:
> > bgpctl help output follows no clear order. I decided to sort all
> > keywords and flags alphabetically. Also fixup the manpage a bit since
> > some additions where added in the wrong spot.
> >
> > I think the output of 'bgpctl show rib help' is the worst (both before and
> > after). It is long and some keywords are not self-explanatory.
> > Still I prefer them to be alphabetically sorted.
>
> I'm ok with this, but see some comments below.
>
> > -.Xr bgpd 8
> > -itself.
>
> I think the previous two lines were removed by accident...
>
> > +.Xr bgpd 8
> > +itself.
>
> ... and added here by mistake.
Fixed
> > static const struct token t_show_mrt[] = {
> > { NOTOKEN, "", NONE, NULL},
> > - { ASTYPE, "as", AS_ALL, t_show_mrt_as},
> > - { ASTYPE, "source-as", AS_SOURCE, t_show_mrt_as},
> > - { ASTYPE, "transit-as", AS_TRANSIT, t_show_mrt_as},
> > - { ASTYPE, "peer-as", AS_PEER, t_show_mrt_as},
> > - { ASTYPE, "empty-as", AS_EMPTY, t_show_mrt},
> > { FLAG, "detail", F_CTL_DETAIL, t_show_mrt},
> > - { FLAG, "ssv", F_CTL_SSV, t_show_mrt},
> > - { KEYWORD, "neighbor", NONE, t_show_mrt_neigh},
> > { FLAG, "peers", F_CTL_NEIGHBORS,t_show_mrt},
> > + { FLAG, "ssv", F_CTL_SSV, t_show_mrt},
>
> Slightly confused here. This sorts FLAG first, then ASTYPE and KEYWORD.
> It breaks alphabetical order. This wasn't done in t_show_rib[].
Also fixed. I probably used a bad sort -k here.
--
:wq Claudio
