Hello,
On Fri, May 05, 2023 at 11:17:50PM +0200, Alexander Bluhm wrote:
> Hi,
>
> I preparation for my TSO in software diff, I would like to cleanup
> the fragment code. Both are very simmilar and I like consistency.
>
> - Use if_output_ml() to send mbuf lists to interfaces. This can
> be used for TSO, fragments, ARP and ND6.
> - Rename variable fml to ml. It will soon be used for TCP segments,
> no need to have the f for fragment in the name.
> - In pf_route6() split the if else block, then tcp_chopper() can
> be easily put in there in the next diff.
> - In ip_fragment() the if (hlen + firstlen < tlen) is a new safety
> check. It makes the code correct for the case where the packet
> was to short to be fragmented. This should not happen, but the
> other functions also have this logic.
>
changes make sense, new code reads better.
> No functional change intended.
I agree I could not spot any side effect.
>
> ok?
>
reads OK to me
sashan
