On Wed, May 10, 2023 at 09:25:43AM +0200, Omar Polo wrote: > On 2023/05/09 19:41:51 -0600, "Todd C. Miller" <todd.mil...@sudo.ws> wrote: > > On Wed, 10 May 2023 00:55:54 +0200, Omar Polo wrote: > > > > > As per subject, here's a few misc nits that would reduce the > > > difference with -portable. There's some printing of time_t via > > > casting to long long, some missing includes (even if in tree it builds > > > nevertheless) and a const for a variable (no idea how it went there in > > > -portable but it's not wrong so including that too.) > > > > OK millert@ > > thanks! > > I forgot to include one off_t cast since it was in a different > directory and -even if off topic because it's not in portable- instead > of "const"-ify only tz why don't mark as const also the two arrays day > and month?
ok. The previous diff used (long long int) and this one now uses (long long). Would be nice to be consistent.