On Mon, May 15, 2023 at 09:34:21AM +0200, Jan Klemkow wrote:
> @@ -251,12 +251,16 @@ struct if_status_description {
> #define IFCAP_VLAN_HWTAGGING 0x00000020 /* hardware VLAN tag
> support */
> #define IFCAP_CSUM_TCPv6 0x00000080 /* can do IPv6/TCP
> checksums */
> #define IFCAP_CSUM_UDPv6 0x00000100 /* can do IPv6/UDP
> checksums */
> -#define IFCAP_TSO 0x00004000 /* TCP segment
> offloading */
> +#define IFCAP_LRO 0x00001000 /* TCP large recv
> offload */
> +#define IFCAP_TSOv4 0x00002000 /* TCP segmentation
> offload */
> +#define IFCAP_TSOv6 0x00004000 /* TCP segmentation
> offload */
> #define IFCAP_WOL 0x00008000 /* can do wake on lan */
I would prefer to keep the numbers of IFCAP_TSO/IFCAP_LRO as this
is just a naming error. Then we have less confusion during the
ifconfig transition phase.
+#define IFCAP_TSOv4 0x00001000
+#define IFCAP_TSOv6 0x00002000
-#define IFCAP_TSO 0x00004000
+#define IFCAP_LRO 0x00004000
> +#define IFCAP_TSO (IFCAP_TSOv4 | IFCAP_TSOv6)
> +
Could you please remove this chunk and expand it, where is used?
This one more define does not make the code clearer. And this flag
IFCAP_TSO had a different meaning before renaming. When it is not
introduced again, the compiler makes sure that no renaming was
forgotten.
bluhm
