On Tue, May 16, 2023 at 10:40:12PM +0300, Vitaliy Makkoveev wrote: > We have "error == 0" in assertion, so I used this idiom instead of > "!error". This is not the fast path, so dropping "maxlen != > mq->mq_maxlen" doesn't provide any performance impact. > > ok?
OK bluhm@ > Index: sys/kern/uipc_mbuf.c > =================================================================== > RCS file: /cvs/src/sys/kern/uipc_mbuf.c,v > retrieving revision 1.285 > diff -u -p -r1.285 uipc_mbuf.c > --- sys/kern/uipc_mbuf.c 5 May 2023 01:19:51 -0000 1.285 > +++ sys/kern/uipc_mbuf.c 16 May 2023 19:34:28 -0000 > @@ -1801,7 +1801,7 @@ sysctl_mq(int *name, u_int namelen, void > case IFQCTL_MAXLEN: > maxlen = mq->mq_maxlen; > error = sysctl_int(oldp, oldlenp, newp, newlen, &maxlen); > - if (!error && maxlen != mq->mq_maxlen) > + if (error == 0) > mq_set_maxlen(mq, maxlen); > return (error); > case IFQCTL_DROPS:
