Hello,
On Thu, May 25, 2023 at 07:14:54AM +0000, Klemens Nanni wrote:
> On Thu, May 25, 2023 at 03:28:45AM +0000, Klemens Nanni wrote:
> > On Thu, May 25, 2023 at 03:20:04AM +0000, Klemens Nanni wrote:
> > > pfsync_in_bus() looks like the only place where the static array
> > > pf_pool_limits[] is accessed without the pf lock, so grab it there.
> > >
> > > Limits themselves are protected by the pf lock and pool(9)s are never
> > > destroyed and have builtint per-pool locks, so the net lock is not
> > > needed.
> > >
> > > (pf_pool_limits[] access in DIOCXCOMMIT remains under pf *and net* lock
> > > until the rest in there gets pulled out of the net lock.)
> > >
> > > Feedback? OK?
> >
> > Correct diff without typo and with missing locking comment.
>
> Diffing pfvar.h instead of pfvar_priv.h helps to get the comment hunk...
looks good to me.
OK sashan
