Hi,
I would suggest to rename ifconfig tcprecvoffload to tcplro. Maybe
it's just because I had to type that long name too often.
With that we have consistent naming:
# ifconfig ix0 tcplro
# sysctl net.inet.tcp.tso=1
Also the coresponding flag are named LRO.
# ifconfig ix1 hwfeatures
ix1: flags=2008843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST,LRO> mtu 1500
hwfeatures=71b7<CSUM_IPv4,CSUM_TCPv4,CSUM_UDPv4,VLAN_MTU,VLAN_HWTAGGING,CSUM_TCPv6,CSUM_UDPv6,TSOv4,TSOv6,LRO>
hardmtu 9198
The feature is quite new, so I have no backward compatiblity concerns.
ok?
bluhm
Index: sbin/ifconfig/ifconfig.8
===================================================================
RCS file: /data/mirror/openbsd/cvs/src/sbin/ifconfig/ifconfig.8,v
retrieving revision 1.396
diff -u -p -r1.396 ifconfig.8
--- sbin/ifconfig/ifconfig.8 1 Jun 2023 18:57:53 -0000 1.396
+++ sbin/ifconfig/ifconfig.8 6 Jun 2023 12:18:07 -0000
@@ -501,7 +501,7 @@ Query and display information and diagno
modules installed in an interface.
It is only supported by drivers implementing the necessary functionality
on hardware which supports it.
-.It Cm tcprecvoffload
+.It Cm tcplro
Enable TCP large receive offload (LRO) if it's supported by the hardware; see
.Cm hwfeatures .
LRO enabled network interfaces modify received TCP/IP packets.
@@ -517,7 +517,7 @@ It is not possible to use LRO with inter
or
.Xr tpmr 4 .
Changing this option will re-initialize the network interface.
-.It Cm -tcprecvoffload
+.It Cm -tcplro
Disable LRO.
LRO is disabled by default.
.It Cm up
Index: sbin/ifconfig/ifconfig.c
===================================================================
RCS file: /data/mirror/openbsd/cvs/src/sbin/ifconfig/ifconfig.c,v
retrieving revision 1.465
diff -u -p -r1.465 ifconfig.c
--- sbin/ifconfig/ifconfig.c 1 Jun 2023 18:57:54 -0000 1.465
+++ sbin/ifconfig/ifconfig.c 6 Jun 2023 12:18:59 -0000
@@ -471,8 +471,8 @@ const struct cmd {
{ "-soii", IFXF_INET6_NOSOII, 0, setifxflags },
{ "monitor", IFXF_MONITOR, 0, setifxflags },
{ "-monitor", -IFXF_MONITOR, 0, setifxflags },
- { "tcprecvoffload", IFXF_LRO, 0, setifxflags },
- { "-tcprecvoffload", -IFXF_LRO, 0, setifxflags },
+ { "tcplro", IFXF_LRO, 0, setifxflags },
+ { "-tcplro", -IFXF_LRO, 0, setifxflags },
#ifndef SMALL
{ "hwfeatures", NEXTARG0, 0, printifhwfeatures },
{ "metric", NEXTARG, 0, setifmetric },
