On Wed, Jun 28, 2023 at 06:37:43PM +0200, Omar Polo wrote:
> since fetch.c revision 1.211 ("strip spaces at end of header lines and
> in chunked encoding headers") ftp removes trailing whitespaces early
> so we don't need to re-do that upon every header we parse.
>
> it can also be misleading since one can wonder why LAST_MODIFIED
> doesn't have " \t" but only "\t", or confront it with rpki-client'
> http.c and notice that there there is no strcspn() call in
> Last-Modified handling.
Who had this kind of confusion? :)
> I've tested it by modifying httpd(8) to append " \t " at the end of
> every header (legal per rfc 7230) and observing that ftp still works
> fine, including mtime handling.
>
> A similar thing could be applied to rpki-client' http.c as well, it
> should work the same.
Could you please send a diff? The files have diverged, but keeping the
shared parts in sync is helpful.
> As a bonus, drop the unused `s' variable in Retry-After handling.
That's also a leftover from r1.209 :)
ok tb
