Re: dt(4), hardclock(9): move interval, profile providers to dedicated callback

[George Koehler]

On Fri, 25 Aug 2023 21:00:34 -0500
Scott Cheloha <scottchel...@gmail.com> wrote:

> @@ -148,4 +185,18 @@ dt_prov_interval_enter(struct dt_provide
>       }
>       smr_read_leave();
>       return 0;
> +}
> +
> +void
> +dt_prov_profile_intr(struct clockintr *cl, void *cf)
> +{
> +     uint64_t count, i;
> +     struct cpu_info *ci = curcpu();
> +
> +     count = clockintr_advance(cl, hardclock_period);
> +     for (i = 0; i < count; i++) {
> +             DT_ENTER(profile, NULL);
> +             if (CPU_IS_PRIMARY(ci))
> +                     DT_ENTER(interval, NULL);
> +     }
>  }

In build of GENERIC bsd.sp,

/usr/src/sys/dev/dt/dt_prov_profile.c:194:19: error: unused variable
'ci' [-Werror,-Wunused-variable]
        struct cpu_info *ci = curcpu();
                         ^
1 error generated.

To unbreak it, I edited the function to be,

void
dt_prov_profile_intr(struct clockintr *cl, void *cf)
{
        uint64_t count, i;
        int primary = CPU_IS_PRIMARY(curcpu());

        count = clockintr_advance(cl, hardclock_period);
        for (i = 0; i < count; i++) {
                DT_ENTER(profile, NULL);
                if (primary)
                        DT_ENTER(interval, NULL);
        }
}