On 28/03/11 14:45, Olivier Crête wrote: > On Mon, 2011-03-28 at 10:59 +0100, Simon McVittie wrote: >> On Fri, 25 Mar 2011 at 16:34:29 +0000, Will Thompson wrote: >>> Are we okay with having a Grand Unified List of Reviewers for all >>> Telepathy components hosted on freedesktop.org, just as commit access is >>> all-or-nothing? >> >> I think this is fine; as Sjoerd said elsewhere in the thread, one of the >> criteria for being a designated reviewer is recognising changes that you're >> not qualified to review. > > My main point wasn'T about the last of qualitication, but about the lack > of unified vision/direction and accountability. If everyone is > responsible, no one is.
I think it makes sense to have named individuals as the maintainers for projects. So maybe we can update the really out of date table on <http://telepathy.freedesktop.org/wiki/Review%20Procedure> to remove the “Other reviewers” column and make the “Maintainer” column better reflect reality. Meanwhile, people who believe themselves to be de-facto reviewers for one or more module at present should subscribe to telepathy-reviewers. Then, reviewers should exercise their own judgement as to whether they're qualified to approve patches for merging (as opposed to saying “this looks good to me but someone else should still look at it”) and the module maintainers can oversee this and pipe up if they think people are over-stepping their review fence? -- Will _______________________________________________ telepathy mailing list telepathy@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/telepathy
