Hey Rohan, On Thu, 2011-09-29 at 00:12 +0530, Rohan Garg wrote:
> I was working on Telepathy KDE and i noticed that the '!=' operator > had not been implemented in Tp::Presence and Tp::PresenceSpec. This > patch fixes that. I know that one could easily use the '==' operator > and implement this functionality in the application using Tp::Presence > itself, but i think that this should be implemented by the > Tp::Presence class itself in order to keep code using the Telepathy > Qt4 API cleaner. First thanks for the patch. The patch is fine and I will apply it to upstream master to be released in 0.7.3. As for future patches, I would like to ask you to please file a bug against Telepathy/tp-qt4 on bugs.freedesktop.org, with the patch keyword, so it's easier to keep track and make review comments. BR, Andre _______________________________________________ telepathy mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/telepathy
