On 06/11/2016 09:04 AM, Alexandr Akulich wrote: > On Fri, Jun 10, 2016 at 9:43 PM, Alexandr Akulich > <akulichalexan...@gmail.com> wrote: >> Hi George, >> >> Can you review commits [3], [4], please? >> >> [3] >> https://github.com/TelepathyQt/telepathy-qt/commit/8864249479ea2adbb5c88378aa082fa18d55f6b0 >> [4] >> https://github.com/TelepathyQt/telepathy-qt/commit/d9354dfe8cca364e4a8c3a44c302ceb714c53911 >>
Ack to both. > > I'm writing NEWS for the 0.9.7 release and thus checking bugzilla for > TpQt related bugs and just found exists bugreport [1] for my fix [2]. > > Can someone confirm that my fix isn't worse than the patch, attached > to the bugreport? > > [1] https://bugs.freedesktop.org/show_bug.cgi?id=65981 > [2] > https://github.com/TelepathyQt/telepathy-qt/commit/d9354dfe8cca364e4a8c3a44c302ceb714c53911 Your patch may not be entirely correct because for some reason all the tpqt_*_generator calls have a DEPENDS some-xincludator, which is what the other patch uses to depend onto, while you depend directly on the spec files. However, this xincludator DEPENDS seems unused and to be honest I don't understand it at all, so for the time being I would say I prefer your patch, since it's cleaner. If you can confirm that it fixes the issue, then that's it. I plan to take a closer look at this build system soon, since it's one of the things that have annoyed me the most in the past. I think it can be simplified a lot. > Do anyone have an idea for codename for the release? Not really, but you can be creative, I'm sure :) Something that relates perhaps to your decision to make the release, or something that relates to the season, or something with the features / bugfixes? Regards, George _______________________________________________ telepathy mailing list telepathy@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/telepathy