Jess Robinson wrote:
> Having discovered a need for a Template::Provider::DBI, I've written one. 
[...]
> http://desert-island.dynodns.net:8888/perldists/etc...

Hi Jess, 

I seem to have missed the boat!  The server doesn't appear to be there 
any more. 

> I needed to make 
> a small change to the Template::Provider module, in order to extract the 
> modify-time checking code out into a sub that I could override. I've 
> attached it to this email, anyone like to apply/comment?

Looks good to me.  It makes a lot of sense to abstract that out.

I should warn you that the Provider sub-system is probably the most
heinously contorted and horrendously unelegant part of TT... no wait!
you've found that out already (sorry!).  It's also the part that is
going to change quite drastically in TT3 and render your code obsolete.

But the, er, "good" news is that TT3 is still some way off and when it
does come, it should make your DBI provider much simpler to implement.
I haven't quite nailed down the new provider sub-system yet (it's one
of the final few things I've got left to do) so having your DBI provider
will be a good reference point for me, if only to see what I'm breaking
and how best to fix it.

In the mean time, I'm moving the DBI plugin into a separate Template-DBI 
distribution.  Initially my plan is just to move non-core things out of
the core, so Template-DBI is just somewhere to put the plugin(s).  But 
I thought it would be nice to have a DBI provider and any other DBI-related
TT modules in there at some point.

So if you're amenable to it, I'd like to look into merging your DBI 
provider into this "core" TT DBI distribution at some point in the 
future.  I'm in the process of moving everything over to subversion 
and you would of course be welcome to have all the neccessary commit 
bits required to maintain it.  

Either way, the Template::Provider patch is applied.  

Many thanks for both that and having a crack at the DBI provider.  
That's brave that is!

A


_______________________________________________
templates mailing list
[email protected]
http://lists.template-toolkit.org/mailman/listinfo/templates

Reply via email to