Andy Wardley wrote:
Josh wrote:
(I know it's readability vs. speed, but in this case I'd rather
have speed.)
That's easy for you to say: you don't have to maintain the code! :-)
------------------------------------------------------------------
LOL! I knew you'd say that. ;) I just didn't think having the code in
both the if and else portions was too unreadable otherwise I wouldn't
have said anything. Like you said the speed difference isn't too huge,
but is noticeable. (Looks like 10-15% in most cases.) If you don't
change that, then for sure look at the backref check patch as that's
very important I think. Once you have a look at (or run) the
benchmarks you'll see how crazily slow the backref replacement we've
worked on has become in comparison to standard perl routines. (1600%
difference in some benchmarks if I remember correctly.)
------------------------------------------------------------------
But I'm sure there are plenty of other vmethods that could do with more
thorough testing and/or documenting. We've got a new t/vmethods/ directory
specially for vmethod tests and the existing tests are in there to cut-n-paste
from, or expand upon.
I'll keep that in mind.
-- Josh
_______________________________________________
templates mailing list
[email protected]
http://lists.template-toolkit.org/mailman/listinfo/templates
