On Mon, 11 Aug 2003 17:58:22 -0700 Aaron Bannert <[EMAIL PROTECTED]> wrote:
> > On Monday, August 11, 2003, at 04:26 PM, Justin Erenkrantz wrote: [...] > >> <url > >responsescript="/path/to/script.py">http://www.example.com/</url> > > > > I wouldn't see an issue just placing this in the main code rather > > than as a separate patch. Just place in the documentation that the > > use of this attribute may distort the timings. > > I agree. +1 > > This patch looks cool, but there's one little problem. If the response > body is bigger > than the internal IO buffers on your system, you'll block trying to > write. Yeah -- like I said -- quick'n'dirty :) > If the > script fails to read or fails to read enough of the body, then flood > and the script will > deadlock. A better (but more complicated) way to do this is with a > pollset, so flood > can poll on reading and writing from the script's stdout and stdin. Actually what flood needs is just writting. The answer from script comes with it's exit code, but yes -- I'll rewrite the patch with using APR's fd_pool features (once I get comfortable with them :) regards, Jacek Prucia
