geoff 2004/01/08 09:15:37
Modified: perl-framework/Apache-Test/lib/Apache Test.pm TestConfigC.pm
TestSSLCA.pm
Log:
fix have_apache_version(), have_min_apache_version(), and
have_min_module_version() to use proper numeric version strings
in comparisons.
Revision Changes Path
1.73 +13 -4 httpd-test/perl-framework/Apache-Test/lib/Apache/Test.pm
Index: Test.pm
===================================================================
RCS file: /home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/Test.pm,v
retrieving revision 1.72
retrieving revision 1.73
diff -u -r1.72 -r1.73
--- Test.pm 22 Dec 2003 19:51:02 -0000 1.72
+++ Test.pm 8 Jan 2004 17:15:37 -0000 1.73
@@ -225,8 +225,7 @@
# have_module requires the perl module
return 0 unless have_module($module);
- my $has_version = $module->VERSION || 0;
- return 1 if $has_version >= $version;
+ return 1 if eval { $module->VERSION($version) };
Are you sure you haven't dropped something here? why did you remove the comparison line?
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
