- $file ||= 'SKIP'; + $file ||= catfile Apache::Test::vars('serverroot'), 'SKIP';
Geoff, you are making a good point of removing the hardcoding of t/
towards the idea of being able to split the test suite.
well, it's an idea that we're all working toward, yourself included :)
;)
There are a few other places where t/ is hardcoded. But at those places, e.g.:
Apache-Test/lib/Apache/TestRun.pm: push @tests, "t/$arg"; Apache-Test/lib/Apache/TestRun.pm: push @tests, "t/$arg.t";
Apache::Test::vars('serverroot') is not available yet.
are you sure? at the top of that function it grabs
my $top_dir = $self->{test_config}->{vars}->{top_dir};
surely if top_dir is available then serverroot is also, since they're both setup in TestConfig::new().
I think you are right.
what I would change there is this
#need the t/ for stat-ing, but don't want to include it in test output $arg =~ [EMAIL PROTECTED](?:\./)?t/@@;
so that t/ is derived from the proper serverroot, then those two lines can concat the proper value back.
Actually that comment is not correct any longer. We now include t/ in the output if you have noticed. Because otherwise T-H won't find those tests. So it probably should be adjusted.
but this is also an aside from the patch I posted, since it seems to be ok (now that I've tested it :)
or maybe I'm not reading you right. it's monday and I'm not all here :)
I think you can commit your patch right away. It looks right to me.
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
