> sub config_defines {
> + my $self = shift;
> +
> my @defines = ();
>
> for my $item (qw(useithreads)) {
> @@ -88,7 +90,9 @@
> push @defines, "-DPERL_\U$item";
> }
>
> - push @defines, map { "-D$_" } split " ",
> shift->{config}->{vars}->{defines};
> + if (my $defines = $self->{config}->{vars}->{defines}) {
> + push @defines, map { "-D$_" } split " ", $defines;
> + }
>
> "@defines";
> }
were you seeing specific undef warnings? I ran it with and without the
-defines option and didn't run across anything. was there a specific case
where {vars}->{defines} wasn't initalized properly in the constructor (like
t/SMOKE or something)?
--Geoff
