Re: qw() and embedded spaces in filname paths

[Geoffrey Young]

Rodent of Unusual Size wrote:
> okey, bug found.  noticed on windows because spaces in filenames
> are more common there, but it happens anywhere.
> 
> here's the deal.  this command:
> 
> perl Makefile.PL -httpd "C:/A B/apache.exe" -apxs "C:/A B/apxs"
> 
> results in the following being put into t/TEST
> 
> %Apache::testConfig::Argv = qw(httpd C:\A B\apache.exe apxs C:\A B\apxs)
> 
> so, duh, the spaces lose their significance because qw() is treating
> the whitespace as delimiters.

does this help?

--Geoff

Index: lib/Apache/TestMM.pm
===================================================================
RCS file: /home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestMM.pm,v
retrieving revision 1.32
diff -u -r1.32 TestMM.pm
--- lib/Apache/TestMM.pm	26 Mar 2004 01:17:08 -0000	1.32
+++ lib/Apache/TestMM.pm	16 Apr 2004 14:56:45 -0000
@@ -89,9 +89,11 @@
     my $body = "BEGIN { eval { require blib; } }\n";
 
     $body .= Apache::TestConfig->modperl_2_inc_fixup;
-
-    if (@Apache::TestMM::Argv) {
-        $body .= "\n\%Apache::TestConfig::Argv = qw(@Apache::TestMM::Argv);\n";
+ 
+    foreach (@Apache::TestMM::Argv) {
+        my ($key, $value) = @Apache::TestMM::Argv[0,1];
+        $body .= "\n\$Apache::TestConfig::Argv{'$key'} = '$value';\n";
+        splice(@Apache::TestMM::Argv,0,2)
     }
 
     my $in = Symbol::gensym();
Index: lib/Apache/TestRun.pm
===================================================================
RCS file: /home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestRun.pm,v
retrieving revision 1.163
diff -u -r1.163 TestRun.pm
--- lib/Apache/TestRun.pm	5 Apr 2004 04:35:21 -0000	1.163
+++ lib/Apache/TestRun.pm	16 Apr 2004 14:56:46 -0000
@@ -1221,8 +1221,10 @@
 
     $body .= Apache::TestConfig->modperl_2_inc_fixup;
 
-    if (@Apache::TestMM::Argv) {
-        $body .= "\n\%Apache::TestConfig::Argv = qw(@Apache::TestMM::Argv);\n";
+    foreach (@Apache::TestMM::Argv) {
+        my ($key, $value) = @Apache::TestMM::Argv[0,1];
+        $body .= "\n\$Apache::TestConfig::Argv{'$key'} = '$value';\n";
+        splice(@Apache::TestMM::Argv,0,2)
     }
 
     my $header = Apache::TestConfig->perlscript_header;