Geoffrey Young wrote:
Not sure what you are talking about above, the only difference between
the two is in line:


blarg, cut and paste error.

without my patch, it looks like this (note it's 1.3)

[EMAIL PROTECTED] perl-framework]$ t/TEST t/apache/contentlength.t -v
/apache/1.3/dso/perl-5.8.4/bin/httpd -d /src/httpd-test/perl-framework/t -f
/src/httpd-test/perl-framework/t/conf/httpd.conf -D APACHE1 -D PERL_USEITHREADS
using Apache/1.3.31-dev

# testing : response codes
# expected: HTTP/1.1 413 Request Entity Too Large
# received: HTTP/1.1 400 Bad Request
not ok 20
# Failed test 20 in t/apache/contentlength.t at line 54 fail #10
FAILED tests 2, 6, 10, 14, 16, 18, 20
        Failed 7/20 tests, 65.00% okay
Failed Test              Stat Wstat Total Fail  Failed  List of Failed
-------------------------------------------------------------------------------
t/apache/contentlength.t               20    7  35.00%  2 6 10 14 16 18 20
[warning] server localhost.localdomain:8529 shutdown

the problem is the lack of this line:

Failed 1/1 test scripts, 0.00% okay. 7/20 subtests failed, 65.00% okay.

which is produced when Test::Harness::_show_results() dies.

Got it. Why not just do this:

Index: Apache-Test/lib/Apache/TestRun.pm
===================================================================
RCS file: 
/home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestRun.pm,v
retrieving revision 1.166
diff -u -r1.166 TestRun.pm
--- Apache-Test/lib/Apache/TestRun.pm   16 Apr 2004 20:29:23 -0000      1.166
+++ Apache-Test/lib/Apache/TestRun.pm   5 May 2004 22:40:28 -0000
@@ -347,6 +347,7 @@

     $SIG{__DIE__} = sub {
         return unless $_[0] =~ /^Failed/i; #dont catch Test::ok failures
+        print $_[0];
         $server->stop(1) if $opts->{'start-httpd'};
         $server->failed_msg("error running tests");
         exit_perl 0;

--
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

Reply via email to