Geoffrey Young wrote:
ping
:)
Must have fell off my radar. How is the following patch ?
--Geoff
Stas Bekman wrote:
Geoffrey Young wrote:
I'm not sure about the name choice. $(TEST_VERBOSE) and $(TEST_FILES)
are the same as other Test packages use. Do they have $TEST_EXTRA_ARGS
too? Otherwise we may better use some name specific to Apache-Test?
MakeMaker looks to support only three: TEST_VERBOSE, TEST_FILE(S), and TESTDB_SW.
so how about APACHE_TEST_EXTRA_ARGS? it's verbose but it shouldn't be
too
bad and it beats making tons of extra targets.
+1
Index: Apache-Test/lib/Apache/TestMM.pm
===================================================================
RCS file: /home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestMM.pm,v
retrieving revision 1.34
diff -u -I$Id -r1.34 TestMM.pm
--- Apache-Test/lib/Apache/TestMM.pm 16 Apr 2004 19:47:42 -0000 1.34
+++ Apache-Test/lib/Apache/TestMM.pm 28 Jun 2004 20:11:47 -0000
@@ -63,12 +63,12 @@
test_clean :
$(FULLPERL) -I$(INST_ARCHLIB) -I$(INST_LIB) \
- t/TEST -clean
+ t/TEST $(APACHE_TEST_EXTRA_ARGS) -clean
run_tests : test_clean
$(PASSENV) \
$(FULLPERL) -I$(INST_ARCHLIB) -I$(INST_LIB) \
- t/TEST -bugreport -verbose=$(TEST_VERBOSE) $(TEST_FILES)
+ t/TEST $(APACHE_TEST_EXTRA_ARGS) -bugreport -verbose=$(TEST_VERBOSE)
$(TEST_FILES)
test :: pure_all run_tests test_clean
signature.asc
Description: OpenPGP digital signature
