On Tue, Sep 27, 2005 at 11:10:29AM +0100, Joe Orton wrote:
> > Is it vaguely right? And can I commit it?
>
> Some nits but otherwise go ahead, great!
>
> 1. use <VirtualHost mod_cache> - the _default_: is not necessary AFAIK
> 2. use just "need 'cache', 'disk_cache'" for the requirements
Excellent, even simpler.
> But this test is going to fail with current releases, is that right?
Yes, and trunk too, it has yet to be fixed anywhere :/
> I aim to keep the tests all passing with each tip-of-branch
> 2.0.x/2.2.x/trunk. So an additional requirement:
>
> need foo, bar, need_min_apache_version('2.3.0')
>
> would be good.
I've added it all, and will commit shortly. I'll get back to working
on a fix.
--
Colm MacCárthaigh Public Key: [EMAIL PROTECTED]
