Joe Orton wrote:
On Mon, Feb 14, 2005 at 03:42:45PM -0500, Stas Bekman wrote:

If you look at the current code with your latest commit Joe, it tries to deal with the same issue twice. The unless condition already tries to tackle that, but won't do it if there is no c extension.

           unless ($mod =~ /\.c$/) {
               $mod = 'mod_' . $mod unless $mod =~ /^mod_/;
               $mod .= '.c'
           }
           next if $cfg->{modules}->{$mod};
           next if $cfg->{modules}->{'mod_' . $mod };

just change that to be:

           $mod = 'mod_' . $mod unless $mod =~ /^mod_/;
           $mod .= '.c' unless $mod =~ /\.c$/
           next if $cfg->{modules}->{$mod};


That's not quite sufficient because it needs to test for *both*
"proxy_http.c" and "mod_proxy_http.c" but I've committed something
similar - thanks.

it's still not perfect. there is a dup and it doesn't do that check in disabled modules. now it checks only mod_foo. I think it should be a for() loop and check both.


--
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

Reply via email to