Paul Wernau wrote: <snip>
> Could we have a pointer to some example journal output? Here you go (portranges only, new fixed bits): http://cr.opensolaris.org/~vkotal/portranges.journal.debug http://cr.opensolaris.org/~vkotal/portranges.journal.non-debug > Just a few small nits... > > - usr/src/suites/net/nc/src/lib/ksh/common_funcs.ksh > > 399,973: It is customary and more succinct to express stdin and stdout > /dev/null redirection as "command >/dev/null 2>&1" rather than calling > out /dev/null twice explicitly for each file descriptor. fixed. > - usr/src/suites/net/nc/tests/portranges/tp_portranges_013_neg.ksh > [through] > - usr/src/suites/net/nc/tests/portranges/tp_portranges_019_neg.ksh > > Curious why you chose to use roman numerals for the portlists in the > td_desc's. It is somewhat confusing, especially when reading the first > one where "I." is ambiguous. I wanted to the description to say something but was in rush to get it right. It's expanded now. > - usr/src/suites/net/nc/tests/portranges/tp_portranges_020_pos.ksh > > 69: see first comment about /dev/null redirection fixed. Incremental webrev is here: http://cr.opensolaris.org/~vkotal/nc_tet-ext_portlist-6754842.stcnv.Paul/ v.
