[
https://issues.apache.org/jira/browse/THRIFT-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607372#action_12607372
]
David Reiss commented on THRIFT-48:
-----------------------------------
Line 74 of the patch, please edit the comment to say "We need remove the old
unix socket if the file exists and nobody is listening on it."
Line 95 of the patch, I personally prefer leaving the parens here.
Line 103 of the patch, please use "is not None" instead of "!="
Other than those nitpicks, I'm fine with this. bmaurer, you wrote the original
Python Unix-domain code. What do you think of it?
> TServerSocket can work with unix socket
> ---------------------------------------
>
> Key: THRIFT-48
> URL: https://issues.apache.org/jira/browse/THRIFT-48
> Project: Thrift
> Issue Type: New Feature
> Components: Library (Python)
> Reporter: Alexander Shigin
> Priority: Minor
> Attachments: thrift-svn-py-unix-socket.patch
>
>
> The patch adds the unix_socket parameter for TServerSocket.
> The patch fixes an error message, because it's confusing to see the message
> "Could not connect to localhost:9090" if you try to connect to /tmp/unix_test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
