[
https://issues.apache.org/jira/browse/THRIFT-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617052#action_12617052
]
Alexander Shigin commented on THRIFT-96:
----------------------------------------
You are right, TSocket::read should follow the same semantic on a different
platform (I don't have an OpenSolaris but it seems recv acts like one on
FreeBSD).
But I think the patch should be applied anyway: it reduces copy-paste in code.
> TSocket.peek fails on FreeBSD
> -----------------------------
>
> Key: THRIFT-96
> URL: https://issues.apache.org/jira/browse/THRIFT-96
> Project: Thrift
> Issue Type: Bug
> Components: Library (C++)
> Reporter: Alexander Shigin
> Attachments: thrift-peek-fix.patch
>
>
> POSIX says what recv(2) should returns 0 if peer has performed a shutdown.
> This feature uses in TBufferedTransport
> {code}
> bool peek() {
> if (rBase_ == rBound_) {
> setReadBuffer(rBuf_.get(), transport_->read(rBuf_.get(), rBufSize_));
> }
> return (rBound_ > rBase_);
> }
> {code}
> The decision works fine on linux, but fails on freebsd. In freebsd, recv
> returns -1 and errno==ECONNRESET.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
